Jzjsnow commented on issue #3329:
URL: https://github.com/apache/amoro/issues/3329#issuecomment-2597325643

   In addition to the issues mentioned in the issue above, there is another 
concern: the default unit for setting 
`flink-conf.jobmanager.memory.process.size` and 
`flink-conf.taskmanager.memory.process.size` in plain numeric strings is `mb`, 
which is inconsistent with the default unit of byte in the flink native 
parameter and may cause inconvenience for users familiar with flink when using 
this parameter.
   
   In #3409, I add `MemorySize` to the `amoro-common` module for parsing 
flink's memory parameters, consistent with flink's native parsing logic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@amoro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to