mansonliwh commented on code in PR #3437:
URL: https://github.com/apache/amoro/pull/3437#discussion_r1959154652
##########
amoro-ams/src/main/java/org/apache/amoro/server/DefaultOptimizingService.java:
##########
@@ -317,19 +318,7 @@ private OptimizingQueue getQueueByToken(String token) {
.orElseThrow(() -> new PluginRetryAuthException("Optimizer has not
been authenticated"));
}
- @Override
- public List<OptimizerInstance> listOptimizers() {
- return ImmutableList.copyOf(authOptimizers.values());
- }
-
- @Override
- public List<OptimizerInstance> listOptimizers(String group) {
- return authOptimizers.values().stream()
- .filter(optimizer -> optimizer.getGroupName().equals(group))
- .collect(Collectors.toList());
- }
-
- @Override
+ // TODO need to use optimizer manager
Review Comment:
The deleteOptimizer interface currently does not invoke methods within the
OptimizerManager. The root cause is that the Service layer still has some
objects that have not been fully converted to a stateless implementation. I
will submit another PR to continue advancing this effort.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
