XBaith commented on code in PR #3467:
URL: https://github.com/apache/amoro/pull/3467#discussion_r1994966054
##########
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/OptimizerGroupController.java:
##########
@@ -263,6 +264,11 @@ public void createResourceGroup(Context ctx) {
String name = (String) map.get("name");
String container = (String) map.get("container");
Map<String, String> properties = (Map) map.get("properties");
+
+ if (!ValidatorUtil.validateGroupName(name)) {
Review Comment:
Do we need a extra util class?
##########
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/component/reverser/IcebergTypeToSparkType.java:
##########
@@ -114,7 +114,6 @@ public DataType primitive(Type.PrimitiveType primitive) {
// use String
return StringType$.MODULE$;
case FIXED:
- return BinaryType$.MODULE$;
Review Comment:
This is a other minor code simplfy, I think we should raise another PR to do
this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
