zhoujinsong commented on code in PR #3428:
URL: https://github.com/apache/amoro/pull/3428#discussion_r2009820740
##########
amoro-format-iceberg/src/main/java/org/apache/amoro/mixed/InternalMixedIcebergCatalog.java:
##########
@@ -121,6 +115,13 @@ protected Table createChangeStore(
return tableMetaStore.doAs(() ->
icebergCatalog.loadTable(changeIdentifier));
}
+ @Override
+ protected TableIdentifier generateChangeStoreIdentifier(TableIdentifier
baseIdentifier) {
+ return TableIdentifier.of(
+ baseIdentifier.namespace(),
+ baseIdentifier.name() + CHANGE_STORE_SEPARATOR +
MixedTable.CHANGE_STORE_IDENTIFIER);
Review Comment:
Both look good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
