(amoro) branch master updated: [AMORO-3490] we got `sync optimizer groups failed` error in ams-error.log (#3491)

[jinsongzhou]

This is an automated email from the ASF dual-hosted git repository.

jinsongzhou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/amoro.git


The following commit(s) were added to refs/heads/master by this push:
     new f78069db1 [AMORO-3490] we got  `sync optimizer groups failed` error in 
ams-error.log (#3491)
f78069db1 is described below

commit f78069db11066bec3c42da898aa084450e9b7c8c
Author: Wang Tao <wtrunw...@gmail.com>
AuthorDate: Fri Mar 28 17:14:22 2025 +0800

    [AMORO-3490] we got  `sync optimizer groups failed` error in ams-error.log 
(#3491)
    
    fix#3490 add new group check
---
 .../apache/amoro/server/DefaultOptimizingService.java    | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git 
a/amoro-ams/src/main/java/org/apache/amoro/server/DefaultOptimizingService.java 
b/amoro-ams/src/main/java/org/apache/amoro/server/DefaultOptimizingService.java
index 77cbddf74..19d0470f7 100644
--- 
a/amoro-ams/src/main/java/org/apache/amoro/server/DefaultOptimizingService.java
+++ 
b/amoro-ams/src/main/java/org/apache/amoro/server/DefaultOptimizingService.java
@@ -558,14 +558,16 @@ public class DefaultOptimizingService extends 
StatedPersistentBase
             .forEach(DefaultOptimizingService.this::deleteResourceGroup);
         resourceGroups.forEach(
             resourceGroup -> {
-              if (optimizingQueueByGroup.containsKey(resourceGroup.getName())
-                  && !optimizingQueueByGroup
-                      .get(resourceGroup.getName())
-                      .getOptimizerGroup()
-                      .equals(resourceGroup)) {
-                updateResourceGroup(resourceGroup);
-              } else {
+              boolean newGroup = 
!optimizingQueueByGroup.containsKey(resourceGroup.getName());
+              if (newGroup) {
                 createResourceGroup(resourceGroup);
+              } else {
+                if (!optimizingQueueByGroup
+                    .get(resourceGroup.getName())
+                    .getOptimizerGroup()
+                    .equals(resourceGroup)) {
+                  updateResourceGroup(resourceGroup);
+                }
               }
             });
       } catch (Throwable t) {