czy006 commented on code in PR #3482:
URL: https://github.com/apache/amoro/pull/3482#discussion_r2030718133


##########
docs/user-guides/configurations.md:
##########
@@ -66,21 +66,23 @@ Self-optimizing configurations are applicable to both 
Iceberg Format and Mixed s
 
 Data-cleaning configurations are applicable to both Iceberg Format and Mixed 
streaming Format.
 
-| Key                                         | Default          | Description 
                                                                                
                                                                                
                                                                                
          |
-|---------------------------------------------|------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| table-expire.enabled                        | true             | Enables 
periodically expire table                                                       
                                                                                
                                                                                
              |
-| change.data.ttl.minutes                     | 10080(7 days)    | Time to 
live in minutes for data of ChangeStore                                         
                                                                                
                                                                                
              |
-| snapshot.keep.duration                      | 720min(12 hours) | 
Table-Expiration keeps the latest snapshots within a specified duration         
                                                                                
                                                                                
                      |
-| snapshot.keep.min-count                     | 1                | Minimum 
number of snapshots retained for table expiration                               
                                                                                
                                                                                
              |
-| clean-orphan-file.enabled                   | false            | Enables 
periodically clean orphan files                                                 
                                                                                
                                                                                
              |
-| clean-orphan-file.min-existing-time-minutes | 2880(2 days)     | Cleaning 
orphan files keeps the files modified within a specified time in minutes        
                                                                                
                                                                                
             |
-| clean-dangling-delete-files.enabled         | true             | Whether to 
enable cleaning of dangling delete files                                        
                                                                                
                                                                                
           |
-| data-expire.enabled                         | false            | Whether to 
enable data expiration                                                          
                                                                                
                                                                                
           |
-| data-expire.level                           | partition        | Level of 
data expiration. Including partition and file                                   
                                                                                
                                                                                
             |
-| data-expire.field                           | NULL             | Field used 
to determine data expiration, supporting timestamp/timestampz/long type and 
string type field in date format                                                
                                                                                
               |
-| data-expire.datetime-string-pattern         | yyyy-MM-dd       | Pattern 
used for matching string datetime                                               
                                                                                
                                                                                
              |
-| data-expire.datetime-number-format          | TIMESTAMP_MS     | Timestamp 
unit for long field. Including TIMESTAMP_MS and TIMESTAMP_S                     
                                                                                
                                                                                
            |
-| data-expire.retention-time                  | NULL             | Retention 
period for data expiration. For example, 1d means retaining data for 1 day. 
Other supported units include h (hour), min (minute), s (second), ms 
(millisecond), etc.                                                             
                           |
+| Key                                         | Default         | Description  
                                                                                
                                                                                
                                                                                
         |
+|---------------------------------------------|-----------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| table-expire.enabled                        | true            | Enables 
periodically expire table                                                       
                                                                                
                                                                                
              |
+| change.data.ttl.minutes                     | 10080(7 days)   | Time to live 
in minutes for data of ChangeStore                                              
                                                                                
                                                                                
         |
+| snapshot.keep.duration                      | 720min(12 hours) | Deprecated. 
Use history.expire.max-snapshot-age-ms instead                                  
                                                                                
                                                                                
         |
+| snapshot.keep.min-count                     | 1               | Deprecated. 
Use history.expire.min-snapshots-to-keep instead                                
                                                                                
                                                                                
         |
+| history.expire.max-snapshot-age-ms          | 43200000(12 hours)        | 
Table-Expiration keeps the latest snapshots within a specified duration         
                                                                                
                                                                                
                      |
+| history.expire.min-snapshots-to-keep        | 1               | Minimum 
number of snapshots retained for table expiration                               
                                                                                
                                                                                
              |
+| clean-orphan-file.enabled                   | false           | Enables 
periodically clean orphan files                                                 
                                                                                
                                                                                
              |
+| clean-orphan-file.min-existing-time-minutes | 2880(2 days)    | Cleaning 
orphan files keeps the files modified within a specified time in minutes        
                                                                                
                                                                                
             |
+| clean-dangling-delete-files.enabled         | true            | Whether to 
enable cleaning of dangling delete files                                        
                                                                                
                                                                                
           |
+| data-expire.enabled                         | false           | Whether to 
enable data expiration                                                          
                                                                                
                                                                                
           |
+| data-expire.level                           | partition       | Level of 
data expiration. Including partition and file                                   
                                                                                
                                                                                
             |
+| data-expire.field                           | NULL            | Field used 
to determine data expiration, supporting timestamp/timestampz/long type and 
string type field in date format                                                
                                                                                
               |
+| data-expire.datetime-string-pattern         | yyyy-MM-dd      | Pattern used 
for matching string datetime                                                    
                                                                                
                                                                                
         |
+| data-expire.datetime-number-format          | TIMESTAMP_MS    | Timestamp 
unit for long field. Including TIMESTAMP_MS and TIMESTAMP_S                     
                                                                                
                                                                                
            |

Review Comment:
   I think it is compatible with iceberg itself  [Table behavior 
properties],WDY?(https://iceberg.apache.org/docs/1.6.1/configuration/#table-behavior-properties)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to