(amoro) branch master updated: [Improvement]: Parameterized Test testOptimizingStatusDisplayValue test in OptimizingStatusTest (#3512)

[jinsongzhou]

This is an automated email from the ASF dual-hosted git repository.

jinsongzhou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/amoro.git


The following commit(s) were added to refs/heads/master by this push:
     new f0c4eed17 [Improvement]: Parameterized Test 
testOptimizingStatusDisplayValue test in OptimizingStatusTest (#3512)
f0c4eed17 is described below

commit f0c4eed178cc3614c92f8b13ecd743d764d19b50
Author: Monil <16ucs...@lnmiit.ac.in>
AuthorDate: Sun Apr 13 19:44:58 2025 -0700

    [Improvement]: Parameterized Test testOptimizingStatusDisplayValue test in 
OptimizingStatusTest (#3512)
    
    parameterized testOptimizingStatusDisplayValue test in OptimizingStatusTest
---
 .../server/optimizing/OptimizingStatusTest.java    | 30 ++++++++++++++--------
 1 file changed, 20 insertions(+), 10 deletions(-)

diff --git 
a/amoro-ams/src/test/java/org/apache/amoro/server/optimizing/OptimizingStatusTest.java
 
b/amoro-ams/src/test/java/org/apache/amoro/server/optimizing/OptimizingStatusTest.java
index 812122fdd..2e0a041ef 100644
--- 
a/amoro-ams/src/test/java/org/apache/amoro/server/optimizing/OptimizingStatusTest.java
+++ 
b/amoro-ams/src/test/java/org/apache/amoro/server/optimizing/OptimizingStatusTest.java
@@ -21,6 +21,11 @@ package org.apache.amoro.server.optimizing;
 import static org.junit.Assert.assertEquals;
 
 import org.junit.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
+
+import java.util.stream.Stream;
 
 public class OptimizingStatusTest {
   @Test
@@ -36,16 +41,21 @@ public class OptimizingStatusTest {
     assertEquals(OptimizingStatus.IDLE, OptimizingStatus.ofCode(700));
   }
 
-  @Test
-  public void testOptimizingStatusDisplayValue() {
-    assertEquals(7, OptimizingStatus.values().length);
+  static Stream<Arguments> displayValueToStatusProvider() {
+    return Stream.of(
+        Arguments.of("full", OptimizingStatus.FULL_OPTIMIZING),
+        Arguments.of("major", OptimizingStatus.MAJOR_OPTIMIZING),
+        Arguments.of("minor", OptimizingStatus.MINOR_OPTIMIZING),
+        Arguments.of("committing", OptimizingStatus.COMMITTING),
+        Arguments.of("planning", OptimizingStatus.PLANNING),
+        Arguments.of("pending", OptimizingStatus.PENDING),
+        Arguments.of("idle", OptimizingStatus.IDLE));
+  }
 
-    assertEquals(OptimizingStatus.FULL_OPTIMIZING, 
OptimizingStatus.ofDisplayValue("full"));
-    assertEquals(OptimizingStatus.MAJOR_OPTIMIZING, 
OptimizingStatus.ofDisplayValue("major"));
-    assertEquals(OptimizingStatus.MINOR_OPTIMIZING, 
OptimizingStatus.ofDisplayValue("minor"));
-    assertEquals(OptimizingStatus.COMMITTING, 
OptimizingStatus.ofDisplayValue("committing"));
-    assertEquals(OptimizingStatus.PLANNING, 
OptimizingStatus.ofDisplayValue("planning"));
-    assertEquals(OptimizingStatus.PENDING, 
OptimizingStatus.ofDisplayValue("pending"));
-    assertEquals(OptimizingStatus.IDLE, 
OptimizingStatus.ofDisplayValue("idle"));
+  @ParameterizedTest
+  @MethodSource("displayValueToStatusProvider")
+  public void testOptimizingStatusDisplayValue(
+      String displayValue, OptimizingStatus expectedStatus) {
+    assertEquals(expectedStatus, 
OptimizingStatus.ofDisplayValue(displayValue));
   }
 }