zhoujinsong commented on code in PR #3529:
URL: https://github.com/apache/amoro/pull/3529#discussion_r2055920819
##########
pom.xml:
##########
@@ -372,6 +373,12 @@
<version>${parquet-avro.version}</version>
</dependency>
+ <dependency>
Review Comment:
It seems `parquet-avro` is dependent on `parquet-jackson` in runtime scope
after pumping up to 1.15.1; this is the reason why we need it here.
##########
amoro-format-iceberg/pom.xml:
##########
@@ -134,6 +134,11 @@
<artifactId>parquet-avro</artifactId>
</dependency>
+ <dependency>
Review Comment:
Do we need to declare it a dependency here, as `amoro-format-iceberg` has
already dependent on `amoro-common`?
##########
amoro-format-mixed/amoro-mixed-trino/src/test/java/org/apache/amoro/trino/mixed/TestKeyedTable.java:
##########
@@ -62,7 +62,7 @@ public void testStats() {
.matches(
"VALUES "
+ "('id', NULL, NULL, 0e0, NULL, '1', '4'), "
- + "('name$name', 429e0, NULL, 0e0, NULL, NULL, NULL), "
+ + "('name$name', 461e0, NULL, 0e0, NULL, NULL, NULL), "
Review Comment:
I have no idea why this change is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
