XBaith commented on code in PR #3532:
URL: https://github.com/apache/amoro/pull/3532#discussion_r2059893333
##########
pom.xml:
##########
@@ -103,7 +104,7 @@
<iceberg.version>1.6.1</iceberg.version>
<paimon.version>0.9.0</paimon.version>
- <hive.version>3.1.1</hive.version>
+ <hive.version>3.1.3</hive.version>
Review Comment:
Cannot cast Object[] to URI[] in `HiveMetaStoreClient#resolveUris`. It was
fixed in hive-standalone-metasotre `3.1.3`
```
08:55:43.202 ERROR org.apache.hadoop.hive.metastore.utils.MetaStoreUtils:
Got exception: java.lang.ClassCastException class [Ljava.lang.Object; cannot be
cast to class [Ljava.net.URI; ([Ljava.lang.Object; and [Ljava.net.URI; are in
module java.base of loader 'bootstrap')
java.lang.ClassCastException: class [Ljava.lang.Object; cannot be cast to
class [Ljava.net.URI; ([Ljava.lang.Object; and [Ljava.net.URI; are in module
java.base of loader 'bootstrap')
at
org.apache.hadoop.hive.metastore.HiveMetaStoreClient.resolveUris(HiveMetaStoreClient.java:262)
~[hive-standalone-metastore-3.1.1.jar:3.1.1]
at
org.apache.hadoop.hive.metastore.HiveMetaStoreClient.<init>(HiveMetaStoreClient.java:182)
~[hive-standalone-metastore-3.1.1.jar:3.1.1]
at
org.apache.hadoop.hive.metastore.HiveMetaStoreClient.<init>(HiveMetaStoreClient.java:137)
~[hive-standalone-metastore-3.1.1.jar:3.1.1]
at
jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
~[?:?]
```
##########
pom.xml:
##########
@@ -71,12 +71,13 @@
</issueManagement>
<properties>
- <maven.compiler.source>8</maven.compiler.source>
- <maven.compiler.target>8</maven.compiler.target>
+ <maven.compiler.source>11</maven.compiler.source>
+ <maven.compiler.target>11</maven.compiler.target>
+ <maven.compiler.release>8</maven.compiler.release>
Review Comment:
Generating class files which target that release:
https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#release
##########
docker/amoro/Dockerfile:
##########
@@ -23,7 +23,7 @@
# --tag apache/amoro:tagname
# .
-FROM eclipse-temurin:8-jdk-jammy as builder
+FROM eclipse-temurin:11-jdk-jammy AS builder
Review Comment:
Replace `as` with `AS` to avoid WARN logs when build docker image
##########
docker/amoro/Dockerfile:
##########
@@ -40,13 +40,13 @@ RUN AMORO_VERSION=`cat pom.xml | grep 'amoro-parent' -C 3 |
grep -Eo '<version>.
&& rm -rf /workspace/amoro
-FROM eclipse-temurin:8-jdk-jammy
+FROM eclipse-temurin:11-jdk-jammy
ARG MAVEN_MIRROR=https://repo.maven.apache.org/maven2
-ENV AMORO_HOME /usr/local/amoro
-ENV AMORO_CONF_DIR ${AMORO_HOME}/conf
-ENV LOG_LEVEL info
+ENV AMORO_HOME=/usr/local/amoro
Review Comment:
Avoid WARN logs when build docker image
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
