zhoujinsong commented on PR #3520: URL: https://github.com/apache/amoro/pull/3520#issuecomment-2834439409
Hi, Thanks for driving this. After I listed all SQL related to `table_optimizing_process`, I found that the condition of some SQL does not contain `table_name`, which may cost poor performance, like: https://github.com/apache/amoro/blob/master/amoro-ams/src/main/java/org/apache/amoro/server/persistence/mapper/OptimizingMapper.java#L147 I think the `table_optimizing_process` might only need a globally unique ID as the primary key, without necessarily including `table_name`. However, the current ID generation rules do indeed carry a risk of duplication. Currently, we use the`currentTimestamp` generation rule, which I understand is for easier cleanup operations. However, perhaps we should optimize the current cleanup logic, for example, by partitioning this table and using DROP PARTITION to perform cleanup more efficiently. #3445 is following the cleaning improvement issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
