zhoujinsong commented on code in PR #3534:
URL: https://github.com/apache/amoro/pull/3534#discussion_r2063200714
##########
amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableService.java:
##########
@@ -275,18 +274,24 @@ public void exploreExternalCatalog(ExternalCatalog
externalCatalog) {
try {
tableIdentifiersFutures.add(
CompletableFuture.supplyAsync(
- () -> {
- try {
- return
externalCatalog.listTables(database).stream()
- .map(TableIdentity::new)
- .collect(Collectors.toSet());
- } catch (Exception e) {
- LOG.error(
- "TableExplorer list tables in database {}
error", database, e);
- return new HashSet<>();
- }
- },
- tableExplorerExecutors));
+ () -> {
+ try {
+ return
externalCatalog.listTables(database).stream()
+ .map(TableIdentity::new)
+ .collect(Collectors.toSet());
+ } catch (Exception e) {
Review Comment:
Hiļ¼can we remove this try-catch here as we already handled the exception
with the `exceptionally ` call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
