zhoujinsong commented on code in PR #3543:
URL: https://github.com/apache/amoro/pull/3543#discussion_r2067790997
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/maintainer/IcebergTableMaintainer.java:
##########
@@ -321,13 +322,19 @@ protected void cleanContentFiles(
// so acquire in advance
// to prevent repeated acquisition
Set<String> validFiles = orphanFileCleanNeedToExcludeFiles();
- LOG.info("Starting cleaning orphan content files for table {}",
table.name());
+ LOG.info(
+ "Starting cleaning orphan content files for table {} before {}",
+ table.name(),
+ new Timestamp(lastTime));
Review Comment:
Hi, should we use ` java.time.Instant` instead of `java.sql.Timestamp` like:
```
java.time.Instant..ofEpochMilli(lastTime)
```
which is more general without any dependency rather than JDK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@amoro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
