zhoujinsong commented on code in PR #53: URL: https://github.com/apache/amoro-site/pull/53#discussion_r2079243612
########## amoro-docs/content/admin-guides/deployment-on-kubernetes.md: ########## @@ -81,7 +81,7 @@ You can obtain the latest official release chart by adding the official Helm rep $ helm repo add amoro https://netease.github.io/amoro/charts $ helm search repo amoro NAME CHART VERSION APP VERSION DESCRIPTION -amoro/amoro 0.1.0 0.7.1 A Helm chart for Amoro +amoro/amoro 0.1.0 0.7.0 A Helm chart for Amoro Review Comment: Line 77 ~ line 90 should be dropped, we do not support this URL any more. ########## amoro-docs/content/admin-guides/managing-optimizers.md: ########## @@ -344,7 +368,10 @@ Or you can submit optimizer in your own Spark task development platform or local ${AMORO_HOME}/plugin/optimizer/spark/optimizer-job.jar \ -a thrift://127.0.0.1:1261 \ -g sparkGroup \ - -p 1 + -p 1 \ Review Comment: The same as above. ########## amoro-docs/content/admin-guides/deployment.md: ########## @@ -31,7 +31,8 @@ You can choose to download the stable release package from [download page](../.. ## System requirements - Java 8 is required. -- Optional: A RDBMS (PostgreSQL 14.x or higher, MySQL 5.5 or higher) Review Comment: We should rollback this change here. ########## amoro-docs/content/admin-guides/managing-optimizers.md: ########## @@ -317,7 +338,10 @@ You can submit optimizer in your own Flink task development platform or local Fl ${AMORO_HOME}/plugin/optimizer/flink/optimizer-job.jar \ -a thrift://127.0.0.1:1261 \ -g flinkGroup \ - -p 1 + -p 1 \ + -eds \ + -dsp /tmp \ + -msz 512 Review Comment: line 342 ~ line 244 can be dropped , these parameters no longer needed. ########## amoro-docs/content/engines/flink/flink-get-started.md: ########## @@ -56,20 +56,20 @@ The Amoro project can be self-compiled to obtain the runtime jar. `mvn clean package -pl ':amoro-mixed-flink-runtime-1.15' -am -DskipTests` -The Flink Runtime Jar is located in the `amoro-mixed-format/amoro-mixed-format-flink/v1.15/amoro-mixed-format-flink-runtime-1.15/target` directory. +The Flink Runtime Jar is located in the `amoro-format-mixed/amoro-format-mixed-flink/v1.15/amoro-format-mixed-flink-runtime-1.15/target` directory. ## Environment preparation Download Flink and related dependencies, and download Flink 1.15/1.16/1.17 as needed. Taking Flink 1.15 as an example: ```shell # Replace version value with the latest Amoro version if needed -AMORO_VERSION=0.7.1-incubating +AMORO_VERSION=0.7.0-incubating Review Comment: ```suggestion AMORO_VERSION=0.8.0-incubating ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
