xxubai commented on code in PR #3571: URL: https://github.com/apache/amoro/pull/3571#discussion_r2099161218
########## amoro-common/src/main/java/org/apache/amoro/serialization/JavaSerializer.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.amoro.serialization; + +import static org.apache.amoro.shade.guava32.com.google.common.base.Preconditions.checkNotNull; + +import java.io.Serializable; + +/** + * JavaSerializer Use KryoSerialize to serialize/deserialize java objects + * + * @param <R> + */ +public class JavaSerializer<R extends Serializable> implements ResourceSerde<R> { Review Comment: @SuppressWarnings("rawtypes") ########## amoro-common/src/main/java/org/apache/amoro/serialization/JavaSerializer.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.amoro.serialization; + +import static org.apache.amoro.shade.guava32.com.google.common.base.Preconditions.checkNotNull; + +import java.io.Serializable; + +/** + * JavaSerializer Use KryoSerialize to serialize/deserialize java objects + * + * @param <R> + */ +public class JavaSerializer<R extends Serializable> implements ResourceSerde<R> { + + private static final KryoSerializer kryoSerialize = new KryoSerializer<>(); + + public static final JavaSerializer INSTANT = new JavaSerializer<>(); + + @Override + @SuppressWarnings("unchecked") + public byte[] serializeResource(R resource) { + checkNotNull(resource); + return kryoSerialize.serializeResource(resource); + } + + @Override + @SuppressWarnings("unchecked") + public DeserializedResource<R> deserializeResource(byte[] input) { + if (input == null) { + return new DeserializedResource<>(null); Review Comment: It seems a bit redundant to just wrap a null value. Additional, I think we can abandon the `DeserializedResource` class and return R directly in the interface. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@amoro.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
