xxubai commented on code in PR #3568:
URL: https://github.com/apache/amoro/pull/3568#discussion_r2100550692
##########
amoro-ams/src/test/java/org/apache/amoro/server/TestDefaultOptimizingService.java:
##########
@@ -205,15 +211,25 @@ public void testPollTaskThreeTimes() {
// 4.retry poll task
OptimizingTask task2 = optimizingService().pollTask(token, THREAD_ID);
- Assertions.assertEquals(task2, task);
+ Assertions.assertEquals(task2.getTaskId(), task.getTaskId());
+ Assertions.assertNotEquals(task2.getTaskInput(), task.getTaskInput());
+ TableOptimizing.OptimizingInput input =
+ SerializationUtil.simpleDeserialize(task.getTaskInput());
+ TableOptimizing.OptimizingInput input2 =
+ SerializationUtil.simpleDeserialize(task2.getTaskInput());
+ Assertions.assertEquals(input2.toString(), input.toString());
Review Comment:
Make changes here because `RewriteFilesInput` is not equals after serialized
via JDK9+. The `MixedTable` can not keep idential bytes
##########
pom.xml:
##########
@@ -103,7 +102,7 @@
<iceberg.version>1.6.1</iceberg.version>
<paimon.version>0.9.0</paimon.version>
- <hive.version>3.1.1</hive.version>
+ <hive.version>3.1.3</hive.version>
Review Comment:
refer to https://github.com/apache/amoro/pull/3532#discussion_r2059893333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
