lrsb commented on code in PR #3546:
URL: https://github.com/apache/amoro/pull/3546#discussion_r2107539816
##########
amoro-format-iceberg/src/main/java/org/apache/amoro/optimizing/plan/AbstractOptimizingPlanner.java:
##########
@@ -151,27 +151,31 @@ public List<RewriteStageTask> planTasks() {
return cacheAndReturnTasks(Collections.emptyList());
}
- List<PartitionEvaluator> evaluators = new
ArrayList<>(needOptimizingPlanMap.values());
+ LinkedList<PartitionEvaluator> evaluators = new
LinkedList<>(needOptimizingPlanMap.values());
Review Comment:
Good question! Seems the optimizing evaluator gets created periodically when
`TableRuntimeRefreshExecutor` runs `tryEvaluatingPendingInput`, so there's no
need to update it. Furthermore, there's not assurance that the partitions we
scheduled were fully optimized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
