Aireed commented on code in PR #3567:
URL: https://github.com/apache/amoro/pull/3567#discussion_r2113584668
##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroServiceContainer.java:
##########
@@ -126,11 +126,14 @@ public static void main(String[] args) {
service.dispose();
LOG.info("AMS service has been shut down");
}));
+ service.startRestServices();
while (true) {
try {
service.waitLeaderShip();
- service.startService();
+ service.startOptimizingService();
service.waitFollowerShip();
+ // become follower, dispose optimizingService stop
+ service.stopOptimizingService();
Review Comment:
But the finally block will dispose all services. so you should use
stopOptimizingService to repalce dsipose in finally block ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
