huyuanfeng2018 commented on code in PR #3581:
URL: https://github.com/apache/amoro/pull/3581#discussion_r2122469556
##########
pom.xml:
##########
@@ -124,7 +124,7 @@
<orc-core.version>1.8.3</orc-core.version>
<awssdk.version>2.24.12</awssdk.version>
<aliyun-sdk-oss.version>3.10.2</aliyun-sdk-oss.version>
- <terminal.spark.version>3.3.2</terminal.spark.version>
+ <terminal.spark.version>3.3.4</terminal.spark.version>
Review Comment:
Is the upgrade to 3.3.4 here because 3.3.2 triggers a bug when using paimon?
##########
amoro-format-mixed/amoro-mixed-spark/amoro-mixed-spark-3-common/src/test/java/org/apache/amoro/spark/test/SparkTestContext.java:
##########
@@ -49,6 +49,8 @@ public class SparkTestContext {
public static final String MIXED_CATALOG_IMPL =
"org.apache.amoro.spark.MixedFormatSparkCatalog";
public static final String SQL_EXTENSIONS_IMPL =
"org.apache.amoro.spark.MixedFormatSparkExtensions"
+ // must PaimonSparkSessionExtensions before
MixedFormatSparkExtensions
Review Comment:
This comment doesn't look right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
