zhoujinsong commented on code in PR #3613: URL: https://github.com/apache/amoro/pull/3613#discussion_r2149162392
########## amoro-optimizer/amoro-optimizer-standalone/src/main/resources/log4j2.xml: ########## @@ -0,0 +1,53 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<Configuration> Review Comment: I recommend excluding this file from the target jar file. ########## amoro-optimizer/amoro-optimizer-standalone/pom.xml: ########## @@ -32,6 +32,10 @@ <name>Amoro Project AMS Standalone Optimizer</name> <url>https://amoro.apache.org</url> + <properties> + <log4j.version>2.20.0</log4j.version> Review Comment: We can reuse the version in the parent pom. ########## amoro-optimizer/amoro-optimizer-standalone/pom.xml: ########## @@ -50,6 +54,29 @@ <artifactId>snakeyaml</artifactId> </dependency> + + <dependency> + <groupId>org.apache.logging.log4j</groupId> + <artifactId>log4j-slf4j-impl</artifactId> + </dependency> Review Comment: `runtime` scope is proper here. ########## amoro-optimizer/amoro-optimizer-standalone/src/main/resources/log4j2.xml: ########## @@ -0,0 +1,53 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<Configuration> + <!--<Configuration status="WARN" monitorInterval="30"> --> + <properties> + <property name="LOG_HOME">logs</property> + </properties> + + <Appenders> + <!--*********************Console log***********************--> + <Console name="consoleAppender" target="SYSTEM_OUT"> + <!--Set log format and color--> + <PatternLayout + pattern="%d %p [%t] [%logger{39}] [%X{RequestId}] - %m%n"/> + </Console> + + <!-- iceberg rest metric reporter logger --> + <Console name="icebergRestMetricReporter" target="SYSTEM_OUT"> Review Comment: The appender can be dropped here. ########## amoro-optimizer/amoro-optimizer-standalone/src/main/resources/log4j2.xml: ########## @@ -0,0 +1,53 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<Configuration> + <!--<Configuration status="WARN" monitorInterval="30"> --> Review Comment: You can remove the configuration here. ########## amoro-optimizer/amoro-optimizer-standalone/src/main/resources/log4j2.xml: ########## @@ -0,0 +1,53 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<Configuration> + <!--<Configuration status="WARN" monitorInterval="30"> --> + <properties> + <property name="LOG_HOME">logs</property> + </properties> + + <Appenders> + <!--*********************Console log***********************--> + <Console name="consoleAppender" target="SYSTEM_OUT"> + <!--Set log format and color--> + <PatternLayout + pattern="%d %p [%t] [%logger{39}] [%X{RequestId}] - %m%n"/> + </Console> + + <!-- iceberg rest metric reporter logger --> + <Console name="icebergRestMetricReporter" target="SYSTEM_OUT"> + <!--Set log format and color--> + <PatternLayout pattern="%m%n"/> + </Console> + </Appenders> + + <Loggers> + <Root level="debug"> + <AppenderRef ref="consoleAppender" level="info"/> + </Root> + <Logger name="org.apache.spark" additivity="false"> Review Comment: You can left the root logger only here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
