MarigWeizhi commented on code in PR #3621:
URL: https://github.com/apache/amoro/pull/3621#discussion_r2151393112
##########
amoro-format-iceberg/src/main/java/org/apache/amoro/optimizing/plan/CommonPartitionEvaluator.java:
##########
@@ -397,7 +397,7 @@ public int getHealthScore() {
long dataFiles = getFragmentFileCount() + getSegmentFileCount();
long dataRecords = getFragmentFileRecords() + getSegmentFileRecords();
- double averageDataFileSize = getNormalizedRatio(dataFilesSize, dataFiles);
+ double averageDataFileSize = dataFilesSize / dataFiles;
Review Comment:
> Is it possible for dataFiles to be 0 ？
I tested it locally, and when there is no data in the partition, this line
of code is unreachable, so dataFiles will not be 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
