zhoujinsong commented on code in PR #3625:
URL: https://github.com/apache/amoro/pull/3625#discussion_r2151817934
##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroManagementConf.java:
##########
@@ -215,6 +215,18 @@ public class AmoroManagementConf {
.defaultValue("")
.withDescription("The Zookeeper address used for high
availability.");
+ public static final ConfigOption<Integer> HA_ZOOKEEPER_SESSION_TIMEOUT_MS =
Review Comment:
Besides, you can add these new configurations in the
`dist/src/main/amoro-bin/conf/config.yaml`.
##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroManagementConf.java:
##########
@@ -215,6 +215,18 @@ public class AmoroManagementConf {
.defaultValue("")
.withDescription("The Zookeeper address used for high
availability.");
+ public static final ConfigOption<Integer> HA_ZOOKEEPER_SESSION_TIMEOUT_MS =
Review Comment:
How about using `ConfigOption<Duration>` here? It supports different units
for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
