xxubai commented on code in PR #3639:
URL: https://github.com/apache/amoro/pull/3639#discussion_r2178870897
##########
amoro-optimizer/amoro-optimizer-common/src/main/java/org/apache/amoro/optimizer/common/OptimizerExecutor.java:
##########
@@ -50,8 +50,28 @@ public void start() {
try {
OptimizingTask task = pollTask();
if (task != null && ackTask(task)) {
- OptimizingTaskResult result = executeTask(task);
Review Comment:
Why do we need an additional try-catch block here, given that
`executeTask(task)` already returns an error result when an exception occurs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
