klion26 commented on code in PR #3590:
URL: https://github.com/apache/amoro/pull/3590#discussion_r2179305101


##########
amoro-ams/src/main/java/org/apache/amoro/server/catalog/CatalogBuilder.java:
##########
@@ -88,6 +90,9 @@ public static ServerCatalog buildServerCatalog(
       case CATALOG_TYPE_HIVE:
         String amsUri = getAmsURI(serverConfiguration);
         catalogMeta.getCatalogProperties().put(CatalogMetaProperties.AMS_URI, 
amsUri);
+        catalogMeta

Review Comment:
   why do we need to add this logic here, seems that we'll set the properties 
when constructing catalogmetadata?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to