zhoujinsong commented on code in PR #3701:
URL: https://github.com/apache/amoro/pull/3701#discussion_r2244512528
##########
dist/src/main/amoro-bin/conf/log4j2.xml:
##########
@@ -44,7 +44,7 @@
<!--Set the log base file size to trigger rolling log file
updates if the size is exceeded-->
<SizeBasedTriggeringPolicy size="2048MB"/>
</Policies>
- <DefaultRolloverStrategy max="25"/>
+ <DefaultRolloverStrategy fileIndex="nomax"/>
Review Comment:
We may not change here; we should limit the debug archive logs.
##########
dist/src/main/amoro-bin/conf/log4j2.xml:
##########
@@ -99,7 +99,7 @@
<Policies>
<SizeBasedTriggeringPolicy size="64MB"/>
</Policies>
- <DefaultRolloverStrategy max="7"/>
+ <DefaultRolloverStrategy fileIndex="nomax"/>
Review Comment:
We should not change the parameter here, too
##########
dist/src/main/amoro-bin/conf/log4j2.xml:
##########
@@ -86,7 +86,7 @@
<!--Set the log base file size to trigger rolling log file
updates if the size is exceeded-->
<SizeBasedTriggeringPolicy size="64MB"/>
</Policies>
- <DefaultRolloverStrategy max="7"/>
+ <DefaultRolloverStrategy fileIndex="nomax"/>
Review Comment:
Similar to the debug appender, we should not change the parameter here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
