Aireed commented on code in PR #3715:
URL: https://github.com/apache/amoro/pull/3715#discussion_r2261832033
##########
amoro-ams/src/test/java/org/apache/amoro/server/dashboard/TestIcebergServerTableDescriptor.java:
##########
@@ -306,17 +307,25 @@ public void insertOptimizingProcess(
Map<String, Long> fromSequence,
Map<String, Long> toSequence) {
doAs(
- OptimizingMapper.class,
+ TableProcessMapper.class,
mapper ->
- mapper.insertOptimizingProcess(
- identifier,
+ mapper.insertProcess(
+ identifier.getId(),
processId,
- targetSnapshotId,
- targetChangeSnapshotId,
status,
- type,
+ type.name(),
Review Comment:
OptimizingType.name is upperCase, OptimizingStatus.name is lowercase，
so we need keep consistence with other` insertProcess` call(like
`OptimizingQueue.java::beginAndPersistProcess`) which use
`OptimizingType.name` and `OptimizingStatus.name`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
