majin1102 commented on code in PR #3661:
URL: https://github.com/apache/amoro/pull/3661#discussion_r2281259096
##########
amoro-ams/src/test/java/org/apache/amoro/server/AmsEnvironment.java:
##########
@@ -310,7 +311,8 @@ public void stopOptimizer() {
.listOptimizers()
.forEach(
resource -> {
-
InternalContainers.get(resource.getContainerName()).releaseResource(resource);
+ ((AbstractOptimizerContainer)
Containers.get(resource.getContainerName()))
Review Comment:
I think this explicit conversion is a little unsafe. If we assure the
Container got from the map always return AbstractOptimizerContainer, then we
may need to modify Containers.get() return type. Otherwise I think a if
instanceOf is suitable for this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
