klion26 commented on code in PR #3726:
URL: https://github.com/apache/amoro/pull/3726#discussion_r2282098209


##########
amoro-ams/src/main/java/org/apache/amoro/server/scheduler/inline/TableRuntimeRefreshExecutor.java:
##########
@@ -63,8 +63,14 @@ protected long getNextExecutingTime(TableRuntime 
tableRuntime) {
 
   private void tryEvaluatingPendingInput(DefaultTableRuntime tableRuntime, 
MixedTable table) {
     DefaultOptimizingState optimizingState = tableRuntime.getOptimizingState();
+    // When planning tasks, tables may be ignored if their plan intervals are 
too small,

Review Comment:
   Can we combine `min-plan-interval` into the execute interval, or in the 
first place of `execute` in the current class?
   
   I think we shouldn't schedule the evaluation if we'll abort it in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to