baiyangtx commented on code in PR #3768:
URL: https://github.com/apache/amoro/pull/3768#discussion_r2328996955
##########
amoro-ams/src/main/java/org/apache/amoro/server/metrics/MetricRegistry.java:
##########
@@ -78,6 +78,7 @@ public <T extends Metric> MetricKey register(
define.getName());
MetricKey key = new MetricKey(define, tags);
+ unregister(key);
Review Comment:
I believe an `unregister` method should be provided and called by the
metrics registrant during disposal, rather than performing the unregister
action at registration time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@amoro.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
