xxubai commented on code in PR #3819:
URL: https://github.com/apache/amoro/pull/3819#discussion_r2435240151
##########
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/CatalogController.java:
##########
@@ -162,6 +165,15 @@ public class CatalogController {
VALIDATE_CATALOGS.add(
CatalogDescriptor.of(
CATALOG_TYPE_CUSTOM, STORAGE_CONFIGS_VALUE_TYPE_HADOOP,
MIXED_ICEBERG));
+
+ VALIDATE_CATALOGS.add(
+ CatalogDescriptor.of(CATALOG_TYPE_REST, STORAGE_CONFIGS_VALUE_TYPE_S3,
ICEBERG));
Review Comment:
MIXED_ICEBERG on S3?
##########
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/CatalogController.java:
##########
@@ -162,6 +165,15 @@ public class CatalogController {
VALIDATE_CATALOGS.add(
CatalogDescriptor.of(
CATALOG_TYPE_CUSTOM, STORAGE_CONFIGS_VALUE_TYPE_HADOOP,
MIXED_ICEBERG));
+
+ VALIDATE_CATALOGS.add(
+ CatalogDescriptor.of(CATALOG_TYPE_REST, STORAGE_CONFIGS_VALUE_TYPE_S3,
ICEBERG));
+ VALIDATE_CATALOGS.add(
+ CatalogDescriptor.of(CATALOG_TYPE_REST,
STORAGE_CONFIGS_VALUE_TYPE_HADOOP, ICEBERG));
+ VALIDATE_CATALOGS.add(
+ CatalogDescriptor.of(CATALOG_TYPE_REST,
STORAGE_CONFIGS_VALUE_TYPE_HADOOP, MIXED_ICEBERG));
+ VALIDATE_CATALOGS.add(
+ CatalogDescriptor.of(CATALOG_TYPE_REST,
STORAGE_CONFIGS_VALUE_TYPE_OSS, ICEBERG));
Review Comment:
MIXED_ICEBERG on OSS?
##########
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/CatalogController.java:
##########
@@ -419,6 +432,12 @@ private CatalogMeta
constructCatalogMeta(CatalogRegisterInfo info, CatalogMeta o
catalogMeta.putToCatalogProperties(
CatalogProperties.CATALOG_IMPL, GlueCatalog.class.getName());
}
+
Review Comment:
How about using an if-else statement?
##########
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/CatalogController.java:
##########
@@ -220,6 +232,7 @@ public void getCatalogTypeList(Context ctx) {
catalogTypes.add(ImmutableMap.of(valueKey, CATALOG_TYPE_HIVE, displayKey,
"Hive Metastore"));
catalogTypes.add(ImmutableMap.of(valueKey, CATALOG_TYPE_HADOOP,
displayKey, "Filesystem"));
catalogTypes.add(ImmutableMap.of(valueKey, CATALOG_TYPE_GLUE, displayKey,
"Glue"));
+ catalogTypes.add(ImmutableMap.of(valueKey, CATALOG_TYPE_REST, displayKey,
"Rest"));
Review Comment:
```suggestion
catalogTypes.add(ImmutableMap.of(valueKey, CATALOG_TYPE_REST,
displayKey, "REST"));
```
##########
amoro-ams/src/main/java/org/apache/amoro/server/catalog/CatalogBuilder.java:
##########
@@ -41,21 +42,23 @@ public class CatalogBuilder {
private static final Map<String, Set<TableFormat>> formatSupportedMatrix =
ImmutableMap.of(
CATALOG_TYPE_HADOOP,
- Sets.newHashSet(
- TableFormat.ICEBERG,
- TableFormat.MIXED_ICEBERG,
- TableFormat.PAIMON,
- TableFormat.HUDI),
- CATALOG_TYPE_GLUE, Sets.newHashSet(TableFormat.ICEBERG,
TableFormat.MIXED_ICEBERG),
- CATALOG_TYPE_CUSTOM, Sets.newHashSet(TableFormat.ICEBERG,
TableFormat.MIXED_ICEBERG),
+ Sets.newHashSet(
+ TableFormat.ICEBERG, TableFormat.MIXED_ICEBERG,
TableFormat.PAIMON, TableFormat.HUDI),
+ CATALOG_TYPE_GLUE,
+ Sets.newHashSet(TableFormat.ICEBERG, TableFormat.MIXED_ICEBERG),
+ CATALOG_TYPE_REST,
+ Sets.newHashSet(TableFormat.ICEBERG, TableFormat.MIXED_ICEBERG),
Review Comment:
Do we need to support Paimon's REST Cataog? @zhoujinsong @czy006
##########
amoro-ams/src/main/java/org/apache/amoro/server/terminal/TerminalManager.java:
##########
@@ -275,6 +275,8 @@ private String catalogConnectorType(CatalogMeta
catalogMeta) {
}
} else if (catalogType.equalsIgnoreCase(CatalogType.CUSTOM.name())) {
return "iceberg";
+ } else if (catalogType.equalsIgnoreCase(CatalogType.REST.name())) {
+ return "iceberg";
Review Comment:
```suggestion
if (tableFormatSet.contains(TableFormat.MIXED_ICEBERG)) {
return "mixed_iceberg";
} else if (tableFormatSet.contains(TableFormat.ICEBERG)) {
return "iceberg";
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
