pan3793 commented on code in PR #3879:
URL: https://github.com/apache/amoro/pull/3879#discussion_r2488828023
##########
README.md:
##########
@@ -118,20 +118,20 @@ Amoro contains modules as below:
Amoro is built using Maven with JDK 8, 11 and 17(required for
`amoro-format-mixed/amoro-mixed-trino` module).
-* Build all modules without `amoro-mixed-trino`: `build/mvn clean package`
-* Build and skip tests: `build/mvn clean package -DskipTests`
-* Build and skip dashboard: `build/mvn clean package -Pskip-dashboard-build`
-* Build and disable disk storage, RocksDB will NOT be introduced to avoid
memory overflow: `build/mvn clean package -DskipTests
-Pno-extented-disk-storage`
-* Build and enable aliyun-oss-sdk: `build/mvn clean package -DskipTests
-Paliyun-oss-sdk`
-* Build with hadoop 2.x(the default is 3.x) dependencies: `build/mvn clean
package -DskipTests -Phadoop2`
-* Specify Flink version for Flink optimizer(the default is 1.20.0): `build/mvn
clean package -DskipTests -Dflink-optimizer.flink-version=1.20.0`
- * If the version of Flink is below 1.15.0, you also need to add the
`-Pflink-optimizer-pre-1.15` parameter: `build/mvn clean package -DskipTests
-Pflink-optimizer-pre-1.15 -Dflink-optimizer.flink-version=1.14.6`
-* Specify Spark version for Spark optimizer(the default is 3.3.3): `build/mvn
clean package -DskipTests -Dspark-optimizer.spark-version=3.3.3`
-* Build `amoro-mixed-trino` module under JDK 17: `build/mvn clean package
-DskipTests -Pformat-mixed-format-trino,build-mixed-format-trino -pl
'amoro-format-mixed/amoro-mixed-trino' -am`.
-* Build all modules: `build/mvn clean package -DskipTests
-Ptoolchain,build-mixed-format-trino`, besides you need config `toolchains.xml`
in `${user.home}/.m2/` dir with content below.
-* Build a distribution package with all formats integrated: `build/mvn clean
package -Psupport-all-formats`
- * Build a distribution package with Apache Paimon format: `build/mvn clean
package -Psupport-paimon-format`
- * Build a distribution package with Apache Hudi format: `build/mvn clean
package -Psupport-hudi-format`
+* Build all modules without `amoro-mixed-trino`: `mvnw clean package`
+* Build and skip tests: `mvnw clean package -DskipTests`
Review Comment:
dot slash is required for Linux/Unix platforms to run command in PWD
```suggestion
* Build and skip tests: `./mvnw clean package -DskipTests`
```
##########
.mvn/wrapper/maven-wrapper.properties:
##########
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# updating the Maven version requires updates to certain documentation and
verification logic
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.9/apache-maven-3.9.9-bin.zip
Review Comment:
the latest maven stable version is 3.9.11, any reason to choose a different
version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
