zhoujinsong commented on code in PR #3886:
URL: https://github.com/apache/amoro/pull/3886#discussion_r2497119730
##########
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/CatalogController.java:
##########
@@ -500,7 +500,8 @@ private CatalogMeta
constructCatalogMeta(CatalogRegisterInfo info, CatalogMeta o
STORAGE_CONFIGS_KEY_S3_ENDPOINT,
S3FileIOProperties.ENDPOINT);
} else if (storageType.equals(STORAGE_CONFIGS_VALUE_TYPE_OSS)) {
- if (TableFormat.valueOf(tableFormats) == TableFormat.ICEBERG) {
+ if (Arrays.asList(TableFormat.ICEBERG, TableFormat.MIXED_ICEBERG)
Review Comment:
`tableFormats` would be a string variable that contains multiple table
formats like `ICEBERG,MIXED_ICEBERG,PAIMON`. We may change the code here to
`info.getTableFormatList().contains(ICEBERG.name()) ||
info.getTableFormatList().contains(MIXED_ICEBERG.name())`.
HDYT?
BTW, the line 509 should be fixed too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
