turboFei commented on code in PR #3953:
URL: https://github.com/apache/amoro/pull/3953#discussion_r2547105436
##########
amoro-common/src/main/java/org/apache/amoro/authentication/TokenAuthenticationProvider.java:
##########
@@ -24,12 +24,11 @@
public interface TokenAuthenticationProvider {
/**
- * TokenAuthenticationProvider is used by the Amoro server authentication
layer to validate Bearer
- * tokens, such as JWT (JSON Web Token), provided in client requests. If the
token is invalid,
- * expired, or fails signature verification, a {@link
SignatureCheckException} should be thrown to
- * deny access.
+ * TokenAuthenticationProvider is used by the Amoro server authentication
layer to validate JSON
+ * Web Token (JWT) provided in client requests. If the token is invalid,
expired, or fails
Review Comment:
Already mentioned JWT here.
@xxubai
It should be Ok to keep the class name as TokenAuthenticationProvider.
For OAuth2 authentication, maybe we can also implement this interface.
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/auth/oauth2/OAuth2Authenticator.java
https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/auth/oauth2/JWTAccessTokenAuthenticator.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
