This is an automated email from the ASF dual-hosted git repository.

jinsongzhou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/amoro.git


The following commit(s) were added to refs/heads/master by this push:
     new 91962e794 nit: remove unused code (#3959)
91962e794 is described below

commit 91962e794ea67acd399787a911d7b5979563e59e
Author: Fei Wang <[email protected]>
AuthorDate: Tue Nov 25 00:31:04 2025 -0800

    nit: remove unused code (#3959)
    
    remove unused code
---
 .../dashboard/controller/OptimizerController.java  | 10 -------
 .../controller/OptimizerGroupController.java       | 32 ----------------------
 2 files changed, 42 deletions(-)

diff --git 
a/amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/OptimizerController.java
 
b/amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/OptimizerController.java
index 18e0fde2f..108f3c8c9 100644
--- 
a/amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/OptimizerController.java
+++ 
b/amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/OptimizerController.java
@@ -25,7 +25,6 @@ import org.apache.amoro.resource.ResourceGroup;
 import org.apache.amoro.resource.ResourceType;
 import org.apache.amoro.server.dashboard.response.OkResponse;
 import org.apache.amoro.server.manager.AbstractOptimizerContainer;
-import org.apache.amoro.server.resource.ContainerMetadata;
 import org.apache.amoro.server.resource.Containers;
 import org.apache.amoro.server.resource.OptimizerInstance;
 import org.apache.amoro.server.resource.OptimizerManager;
@@ -98,13 +97,4 @@ public class OptimizerController {
     optimizerManager.createResource(resource);
     ctx.json(OkResponse.of("success to create optimizer"));
   }
-
-  /** check if optimizerGroup can be deleted url = /optimize/containers/get */
-  public void getContainers(Context ctx) {
-    ctx.json(
-        OkResponse.of(
-            Containers.getMetadataList().stream()
-                .map(ContainerMetadata::getName)
-                .collect(Collectors.toList())));
-  }
 }
diff --git 
a/amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/OptimizerGroupController.java
 
b/amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/OptimizerGroupController.java
index 8aba3989f..fac5b8967 100644
--- 
a/amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/OptimizerGroupController.java
+++ 
b/amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/OptimizerGroupController.java
@@ -184,38 +184,6 @@ public class OptimizerGroupController {
     ctx.json(OkResponse.of(optimizerResourceInfo));
   }
 
-  /**
-   * release optimizer.
-   *
-   * @pathParam jobId
-   */
-  public void releaseOptimizer(Context ctx) {
-    String resourceId = ctx.pathParam("jobId");
-    Preconditions.checkArgument(
-        !resourceId.isEmpty(), "resource id can not be empty, maybe it's a 
external optimizer");
-
-    List<OptimizerInstance> optimizerInstances =
-        optimizerManager.listOptimizers().stream()
-            .filter(e -> resourceId.equals(e.getResourceId()))
-            .collect(Collectors.toList());
-    Preconditions.checkState(
-        !optimizerInstances.isEmpty(),
-        String.format(
-            "The resource ID %s has not been indexed" + " to any optimizer.", 
resourceId));
-    Resource resource = optimizerManager.getResource(resourceId);
-    resource.getProperties().putAll(optimizerInstances.get(0).getProperties());
-    ResourceContainer rc = Containers.get(resource.getContainerName());
-    Preconditions.checkState(
-        rc instanceof AbstractOptimizerContainer,
-        "Cannot release optimizer on non-optimizer resource container %s.",
-        resource.getContainerName());
-    ((AbstractOptimizerContainer) rc).releaseResource(resource);
-
-    optimizerManager.deleteResource(resourceId);
-    optimizerManager.deleteOptimizer(resource.getGroupName(), resourceId);
-    ctx.json(OkResponse.of("Success to release optimizer"));
-  }
-
   /** scale out optimizers, url:/optimizerGroups/{optimizerGroup}/optimizers. 
*/
   public void scaleOutOptimizer(Context ctx) {
     String optimizerGroup = ctx.pathParam("optimizerGroup");

Reply via email to