huyuanfeng2018 commented on code in PR #3964:
URL: https://github.com/apache/amoro/pull/3964#discussion_r2564663170
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/maintainer/IcebergTableMaintainer.java:
##########
@@ -790,6 +818,9 @@ protected static Expression getDataExpression(
DateTimeFormatter.ofPattern(
expirationConfig.getDateTimePattern(),
Locale.getDefault()));
return Expressions.lessThanOrEqual(field.name(), expireDateTime);
+ case DATE:
+ int expireDays = calExpireDaysForDate(expireTimestamp);
Review Comment:
```
LocalDate expireDate = Instant.ofEpochMilli(expireTimestamp)
.atZone(getDefaultZoneId(field)) //
.toLocalDate();
int expireDays = (int) expireDate.plusDays(1).toEpochDay();
return expireDays;
```
WDYT？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
