baiyangtx commented on code in PR #3997:
URL: https://github.com/apache/amoro/pull/3997#discussion_r2605058447
##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroManagementConf.java:
##########
@@ -247,6 +259,18 @@ public class AmoroManagementConf {
.defaultValue(Duration.ofSeconds(300))
.withDescription("The Zookeeper connection timeout in
milliseconds.");
+ public static final ConfigOption<java.time.Duration> HA_LEASE_TTL =
+ ConfigOptions.key("ha.lease-ttl")
+ .durationType()
+ .defaultValue(java.time.Duration.ofSeconds(30))
+ .withDescription("TTL of HA lease.");
+
+ public static final ConfigOption<String> HA_JDBC_LEASE_TABLE =
Review Comment:
I think this should not be configurable.
##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroManagementConf.java:
##########
@@ -536,6 +560,10 @@ public class AmoroManagementConf {
public static final String DB_TYPE_MYSQL = "mysql";
public static final String DB_TYPE_POSTGRES = "postgres";
+ // HA config
+ public static final String HA_TYPE_ZK = "zk";
+ public static final String HA_TYPE_JDBC = "jdbc";
Review Comment:
HA_TYPE_DATABASE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
