czy006 commented on code in PR #3915:
URL: https://github.com/apache/amoro/pull/3915#discussion_r2608928461
##########
amoro-format-paimon/src/main/java/org/apache/amoro/formats/paimon/PaimonTableDescriptor.java:
##########
@@ -579,6 +582,21 @@ public List<ConsumerInfo>
getTableConsumerInfos(AmoroTable<?> amoroTable) {
return consumerInfos;
}
+ @Override
+ public StatisticsBaseInfo getTableStatistics(AmoroTable<?> amoroTable) {
+ FileStoreTable table = getTable(amoroTable);
+ if (!table.statistics().isPresent()) {
+ return new PaimonStatisticInfo();
+ }
+ Statistics statistics = table.statistics().get();
+ return new PaimonStatisticInfo(
+ statistics.snapshotId(),
+ statistics.schemaId(),
+ statistics.mergedRecordCount().getAsLong(),
+ statistics.mergedRecordSize().getAsLong(),
+ Collections.emptyMap());
Review Comment:
What's about **colStats** info ?
##########
amoro-format-hudi/src/main/java/org/apache/amoro/formats/hudi/HudiTableDescriptor.java:
##########
@@ -725,6 +726,12 @@ public List<ConsumerInfo>
getTableConsumerInfos(AmoroTable<?> amoroTable) {
return Collections.emptyList();
}
+ @Override
+ public StatisticsBaseInfo getTableStatistics(AmoroTable<?> amoroTable) {
+ // hudi doesn't support statistics
+ return new StatisticsBaseInfo();
Review Comment:
The default implementation we can make in the interface is：`throw new
UnsupportedOperationException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
