HuangFru commented on code in PR #4005:
URL: https://github.com/apache/amoro/pull/4005#discussion_r2610363692
##########
amoro-common/src/main/java/org/apache/amoro/table/TableMetaStore.java:
##########
@@ -179,6 +181,7 @@ private TableMetaStore(Configuration configuration) {
this.krbPrincipal = null;
this.accessKey = null;
this.secretKey = null;
+ this.configuration = configuration;
Review Comment:
Why not just create a `RuntimeContext` here and set it. So you don't need to
modify `getRuntimeContext()`.
The current code is OK with me, just my humble take.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
