linjianchang commented on code in PR #3992:
URL: https://github.com/apache/amoro/pull/3992#discussion_r2625482904


##########
amoro-ams/pom.xml:
##########
@@ -228,6 +228,11 @@
             <artifactId>derby</artifactId>
         </dependency>
 
+        <dependency>
+            <groupId>com.dameng</groupId>
+            <artifactId>DmJdbcDriver18</artifactId>
+        </dependency>

Review Comment:
   > I don’t think Dameng needs to be included in the release. Similar to 
MySQL, users who need it can add the JDBC dependency manually, rather than 
having it as a standard component.
   
   Aleady modified!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to