wardlican commented on PR #3856: URL: https://github.com/apache/amoro/pull/3856#issuecomment-3696324246
> o whether we can use the design > @wardlican I have the same concern: could simply setting it to the maximum value result in a single file being excessively large? Could we perhaps refer to Spark's estimation logic？ Refer to https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/actions/SizeBasedFileRewritePlanner.java#L199-L206 The current implementation is based on the implementation of SizeBasedFileRewritePlanner; please help review it. @xxubai -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
