davedwwang opened a new issue, #4030:
URL: https://github.com/apache/amoro/issues/4030

   ### Search before asking
   
   - [x] I have searched in the 
[issues](https://github.com/apache/amoro/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### What would you like to be improved?
   
   Currently, in the Apache Amoro project, if the JUnit 5 API is used but the 
corresponding junit-jupiter-engine is missing (or similarly for JUnit 4 and 
junit-vintage-engine), Maven Surefire might silently ignore the test cases. 
This leads to a false sense of security where the build passes even if tests 
are not actually executed.
   
   To improve the robustness of the CI/CD pipeline and ensure all tests are 
strictly executed, we should enforce the presence of these engines during the 
build's validate phase.
   
   ### How should we improve?
   
   1. Introduce maven-enforcer-plugin: Add the plugin to the amoro-ams (or 
root) pom.xml.
   2. Add JUnit 5 Engine Check: Ensure that if the project has dependencies, it 
must contain junit-jupiter-engine to prevent silent ignoring of JUnit 5 tests.
   3. Add JUnit 4 Engine Check: Ensure that junit-vintage-engine is present to 
support the execution of legacy JUnit 4 tests.
   4. Align with Apache Paimon Security Standards: Referenced the security 
practices of Apache Paimon to introduce stricter dependency validation.
   
   ### Are you willing to submit PR?
   
   - [x] Yes I am willing to submit a PR!
   
   ### Subtasks
   
   _No response_
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to