turboFei commented on code in PR #4009:
URL: https://github.com/apache/amoro/pull/4009#discussion_r2659315692
##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroManagementConf.java:
##########
@@ -328,6 +328,29 @@ public class AmoroManagementConf {
"User-defined password authentication implementation of"
+ "
org.apache.amoro.authentication.PasswdAuthenticationProvider");
+ public static final ConfigOption<String> HTTP_SERVER_LOGIN_AUTH_PROVIDER =
+ ConfigOptions.key("http-server.login-auth-provider")
+ .stringType()
+ .defaultValue(DefaultPasswdAuthenticationProvider.class.getName())
+ .withDescription(
+ "User-defined login authentication implementation of"
+ + "
org.apache.amoro.authentication.PasswdAuthenticationProvider");
+
+ public static final ConfigOption<String>
HTTP_SERVER_LOGIN_AUTH_LDAP_USERPARTTERN =
Review Comment:
typo: `PARTTERN` -> `PATTERN`
##########
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/DashboardServer.java:
##########
@@ -92,6 +92,7 @@ public class DashboardServer {
private final PasswdAuthenticationProvider basicAuthProvider;
private final TokenAuthenticationProvider jwtAuthProvider;
+
Review Comment:
nit: unnecessary change
##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroManagementConf.java:
##########
@@ -328,6 +328,29 @@ public class AmoroManagementConf {
"User-defined password authentication implementation of"
+ "
org.apache.amoro.authentication.PasswdAuthenticationProvider");
+ public static final ConfigOption<String> HTTP_SERVER_LOGIN_AUTH_PROVIDER =
+ ConfigOptions.key("http-server.login-auth-provider")
+ .stringType()
+ .defaultValue(DefaultPasswdAuthenticationProvider.class.getName())
+ .withDescription(
+ "User-defined login authentication implementation of"
+ + "
org.apache.amoro.authentication.PasswdAuthenticationProvider");
+
+ public static final ConfigOption<String>
HTTP_SERVER_LOGIN_AUTH_LDAP_USERPARTTERN =
Review Comment:
recommend: `USER_PATTERN`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
