czy006 commented on code in PR #4024: URL: https://github.com/apache/amoro/pull/4024#discussion_r2661572601
########## amoro-common/src/main/java/org/apache/amoro/maintainer/MaintainerMetrics.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.amoro.maintainer; + +/** + * Metrics collector interface for table maintenance operations. Implementations can collect metrics + * to different monitoring systems. + */ +public interface MaintainerMetrics { + + /** + * Record orphan data files cleaning result. + * + * @param expected expected number of files to clean + * @param cleaned actual number of files cleaned + */ + void recordOrphanDataFilesCleaned(int expected, int cleaned); Review Comment: The current solution is a temporary adaptation, as the monitoring function is not within the scope of this modification. This interface is designed to be compatible with **TableOrphanFilesCleaningMetrics**, and will be improved in subsequent pull requests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
