czy006 commented on code in PR #4045: URL: https://github.com/apache/amoro/pull/4045#discussion_r2746379973
########## amoro-ams/src/main/java/org/apache/amoro/server/table/AbstractTableMaintainerMetrics.java: ########## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.amoro.server.table; + +import static org.apache.amoro.metrics.MetricDefine.defineCounter; +import static org.apache.amoro.metrics.MetricDefine.defineGauge; + +import org.apache.amoro.ServerTableIdentifier; +import org.apache.amoro.maintainer.MaintainerMetrics; +import org.apache.amoro.metrics.MetricDefine; + +/** + * Abstract base class for table maintenance operation metrics + * + * <p>Responsibilities: + * + * <ul> + * <li>Define all MetricDefine constants + * <li>Provide template methods for metrics registration + * <li>Handle tags (catalog, database, table, table_format, operation_type) + * </ul> + * + * <p>Note: All metrics include the table_format tag to distinguish Iceberg and Paimon tables + */ +public abstract class AbstractTableMaintainerMetrics extends AbstractTableMetrics Review Comment: I'm worried that on different lake formats, there might be some unique indicators of their own, so it's abstract. Although we have added the TableFormat identifier inside, this is only for monitoring and distinction. In terms of code, we cannot isolate and distinguish it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
