czy006 commented on code in PR #4069:
URL: https://github.com/apache/amoro/pull/4069#discussion_r2762033993
##########
amoro-ams/pom.xml:
##########
@@ -510,7 +510,6 @@
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>${guava.version}</version>
Review Comment:
This is a terrible dependency disaster, but there seems to be no better way
to resolve package sharing conflicts. I suggest that this guava be named
**${guava-hive.version}** as it is related to the version of hive guava
##########
amoro-ams/pom.xml:
##########
@@ -510,7 +510,6 @@
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>${guava.version}</version>
Review Comment:
This is a terrible dependency disaster, but there seems to be no better way
to resolve package sharing conflicts. I suggest that this guava be named
**${guava-hive.version}** as it is related to the version of hive guava cc
@j1wonpark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
