klion26 commented on code in PR #4038:
URL: https://github.com/apache/amoro/pull/4038#discussion_r2763432818
##########
amoro-common/src/main/java/org/apache/amoro/config/OptimizingConfig.java:
##########
@@ -318,6 +324,34 @@ public OptimizingConfig setEvaluationMseTolerance(long
evaluationMseTolerance) {
return this;
}
+ public boolean isRefreshTableAdaptiveEnabled(long minInterval) {
Review Comment:
Why do we need to pass in this parameter? will compare the
`refreshTableAdaptiveMaxIntervalMs` to a default value in the current class be
better?
The logic here seems is different than the doc below `The maximum time
interval in milliseconds to refresh table metadata. 0 means disable adaptive
refresh.`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
