klion26 commented on code in PR #4043:
URL: https://github.com/apache/amoro/pull/4043#discussion_r2772619729
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/OptimizingQueue.java:
##########
@@ -141,6 +141,9 @@ private void initTableRuntime(DefaultTableRuntime
tableRuntime) {
mapper -> mapper.getProcessState(tableRuntime.getProcessId()));
process = new TableOptimizingProcess(tableRuntime, meta, state);
tableRuntime.recover(process);
+ if (process.getStatus() == ProcessStatus.SUCCESS) {
Review Comment:
Will place this logic in `tableRuntime.recover(process)` be better?
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/OptimizingQueue.java:
##########
@@ -500,6 +503,7 @@ public TableOptimizingProcess(
if (processState.getToSequence() != null) {
toSequence = processState.getToSequence();
}
+ this.status = processMeta.getStatus();
Review Comment:
Just curious, why do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
