klion26 commented on code in PR #4076:
URL: https://github.com/apache/amoro/pull/4076#discussion_r2781948153


##########
amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableRuntime.java:
##########
@@ -311,9 +311,9 @@ public DefaultTableRuntime refresh(AmoroTable<?> table) {
     TableConfiguration newConfiguration = 
TableConfigurations.parseTableConfig(tableConfig);
     TableConfiguration oldConfiguration = getTableConfiguration();
     boolean configChanged = !newConfiguration.equals(oldConfiguration);

Review Comment:
   Seems the `configChanged` has never been used, maybe we can return 
immediately if configChanged is false?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to