juiceyang commented on PR #4047: URL: https://github.com/apache/amoro/pull/4047#issuecomment-3894481030
> Hi @juiceyang, thanks for working on this issue! > > I've been looking into the same problem. I think the root cause is actually in TableEntriesScan itself — the entries metadata table returns a unified partition struct containing fields from all PartitionSpecs, but buildDataFile() and buildDeleteFile() pass this directly to withPartition() without projecting it to the spec-specific partition type. Your current approach works around this in getDanglingDeleteFiles() by reading manifests directly, but other callers of TableEntriesScan would still hit the same issue. I'd like to submit a fix at the TableEntriesScan level to address the root cause. Would that be okay with you, or would you prefer to update this PR to fix it there instead? Hi @j1wonpark! I agree that root cause is in TableEntriesScan. I’ve only changed one spot for now, mainly to keep the change as small as possible and minimize impact. If you can fix it at the TableEntriesScan level, that would be a better and more thorough solution. Please go ahead and submit a separate PR following your approach. Once your PR fixes the issue, I’ll close mine. This problem has been bothering us for a while—thanks a lot for your work and contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
