majin1102 commented on code in PR #4097:
URL: https://github.com/apache/amoro/pull/4097#discussion_r2835980108
##########
amoro-common/src/main/java/org/apache/amoro/process/ProcessFactory.java:
##########
@@ -44,5 +63,5 @@ public interface ProcessFactory {
* @param state state of the process
* @return target process which has not been submitted yet.
*/
- AmoroProcess recover(TableRuntime tableRuntime, TableProcessState state);
+ TableProcess recover(TableRuntime tableRuntime, TableProcessStore store);
Review Comment:
I think we should also use Optional here for the case something went wrong
with the recovering or incapatibility issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
