baiyangtx commented on code in PR #4097:
URL: https://github.com/apache/amoro/pull/4097#discussion_r2850519858
##########
amoro-common/src/main/java/org/apache/amoro/process/ProcessFactory.java:
##########
@@ -44,5 +63,5 @@ public interface ProcessFactory {
* @param state state of the process
* @return target process which has not been submitted yet.
*/
- AmoroProcess recover(TableRuntime tableRuntime, TableProcessState state);
+ TableProcess recover(TableRuntime tableRuntime, TableProcessStore store);
Review Comment:
When the recover method is called, there must be a record of Process
information in a managed state within the system database. From a system‑level
perspective, if recovery is not possible at this point, it should be considered
an abnormal situation, meaning the system needs to clean up resources and mark
the Process as failed or abnormal. Therefore, I suggest explicitly indicating
through an exception that this Process can no longer be recovered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
